Implements the nodes/full_types endpoint for the FastAPI
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
changed the title
nodes/full_types endpoint for the FastAPI
agoscinski
force-pushed
the
nodes-full_types-endpoint
branch
3 times, most recently
from
2e77185
to
f3907d7
Compare
eimrek
requested changes
Nov 21, 2024
There was a problem hiding this comment.
thanks @agoscinski
The endpoint fails for my use case, due to a CalcJobNode.
agoscinski
force-pushed
the
nodes-full_types-endpoint
branch
from
3109b30
to
3962602
Compare
eimrek
approved these changes
Nov 22, 2024
The logic is mainly copied from aiida-core with slight adaptations to resolve type checker errors.
agoscinski
force-pushed
the
nodes-full_types-endpoint
branch
from
276dcb5
to
514b3b5
Compare
The disadvantage of removing the `pull_request` as trigger event for an GitHub workflow is that it does not trigger for pushes from a foreign repo. To run the workflow also in this case without running the workflow twice for PRs based on the original repo we introduce an if case that runs the `pull_request` event only when it from a foreign repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skip GraphQL for now. The logic is mainly copied from aiida-core with slight adaptations to
resolve type checker errors.